MCAD controller shows data race conditions when running e2e tests

[z103cb]

When executing the end to end test against MCAD controller compiled with -race flag a number of race conditions are detected. The branch used for this test is the quota-management.

We need to understand the underlying cause and effect the necessary changes.

The full log is attached to this issue.

[z103cb]

The log of the race detected.

mcad-conttroler.race.txt

[z103cb]

It seems that some of the race conditions can be attributed to the unprotected read and write of the schedulingAW variable.

//XController the AppWrapper Controller type
type XController struct {
....
  // Active Scheduling AppWrapper
  schedulingAW *arbv1.AppWrapper
}

[asm582]

@z103cb Thanks for reporting the issue, do we know if the race condition on schedulingAW *arbv1.AppWrapper exists across multiple runs?

[z103cb]

@z103cb Thanks for reporting the issue, do we know if the race condition on schedulingAW *arbv1.AppWrapper exists across multiple runs?

Yes, I have observed the issue on multiple runs of the e2e tests. I did not attached them as they would not provide additional value. This bug has been present in the codebase for some time now.