Skip to content

feat: add comment about tearing down ray clusters to cluster.apply() #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged

feat: add comment about tearing down ray clusters to cluster.apply() #837

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/codeflare_sdk/ray/cluster/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,15 +219,17 @@ def apply(self, force=False):
force_conflicts=force,
)
print(
f"AppWrapper: '{name}' configuration has successfully been applied"
f"AppWrapper: '{name}' configuration has successfully been applied. For optimal resource management, you should delete this Ray Cluster when no longer in use."
)
else:
api_version = "ray.io/v1"
api_instance = crds.get(api_version=api_version, kind="RayCluster")
self._component_resources_apply(
namespace=namespace, api_instance=api_instance
)
print(f"Ray Cluster: '{name}' has successfully been applied")
print(
f"Ray Cluster: '{name}' has successfully been applied. For optimal resource management, you should delete this Ray Cluster when no longer in use."
)
except AttributeError as e:
raise RuntimeError(f"Failed to initialize DynamicClient: {e}")
except Exception as e: # pragma: no cover
Expand Down