Skip to content

task(RHOAIENG-26192): Removed dep fields head_gpus + num_gpus #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chipspeak
Copy link
Contributor

@chipspeak chipspeak commented Jun 10, 2025

Issue link

Jira Link

What changes have been made

head_gpus and num_gpus have reached the end of their deprecation notice period. These values and related logic have been removed as per the Jira.

Verification steps

  1. Build a version of the CodeFlare SDK based on this PR.
  2. Pip install it in a Jupyter Notebook running in RHOAI.
  3. Attempt to use the deprecated values when defining a cluster.
  4. This should now throw an unexpected keyword argument versus previous logic.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Signed-off-by: Pat O'Connor <paoconno@redhat.com>
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.54%. Comparing base (68d1f6c) to head (3748bf2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
+ Coverage   92.48%   92.54%   +0.06%     
==========================================
  Files          24       24              
  Lines        1423     1409      -14     
==========================================
- Hits         1316     1304      -12     
+ Misses        107      105       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chipspeak
Copy link
Contributor Author

Verified via e2e, pytests and using an SDK build based on this PR in RHOAI. See below screenshot.
Previously, this would highlight the fields being deprecated and reassign the values to head_extended_resource_requests etc but now this should just throw an error as with any unsupported field.
Screenshot 2025-06-10 at 11 57 15

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2025
Copy link
Contributor

openshift-ci bot commented Jun 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kryanbeane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit cb70510 into project-codeflare:main Jun 10, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants