Skip to content

Add functions for accessing ray job logs #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

MichaelClifford
Copy link
Contributor

This PR adds 3 new functions to the Cluster class list_jobs , job_status, job_logs so that a user can get some insight into their submitted ray jobs.

It also includes a clean up to cluster_dashboard_uri to prevent it from returning non-dashboard uri's

@MichaelClifford MichaelClifford force-pushed the rayCommands branch 4 times, most recently from 151ad70 to 4fa4d09 Compare January 16, 2023 15:38
Copy link
Collaborator

@Maxusmusti Maxusmusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all LGTM, I would just add type hints and return types to the new function headers, then should be good to merge

@MichaelClifford
Copy link
Contributor Author

Thanks @Maxusmusti, added the type hints

Copy link
Collaborator

@Maxusmusti Maxusmusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelClifford MichaelClifford merged commit 2eb8c1a into project-codeflare:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants