create dashboard route with raycluster #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Maxusmusti
approved these changes
Oct 31, 2022
atinsood
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
LGTM, most of these changes are in generating template and you and mustafa are more familiar with this. but the changes look good.
we will need to update these
https://github.com/openshift-psap/codeflare-sdk/blob/main/src/codeflare_sdk/utils/pretty_print.py#L46
https://github.com/openshift-psap/codeflare-sdk/blob/main/src/codeflare_sdk/cluster/cluster.py#L61
you might need to follow a workaround like this https://github.com/openshift-psap/codeflare-sdk/pull/22/files#diff-5706a96c5346dd54a22370211260411363c4ed41d798fddf240eb8983b1366eaR49
|
sounds good. @atinsood Thanks for the review all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the AppWrapper Template and the
generate_yaml.pycode to deploy a route to the ray dashboard alongside the ray cluster.Note: this still assumes
defaultis the namespace we will be using. Can be updated in a future PR along with #23