Skip to content

Display input for KubeRay parameter and check for existence #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ChristianZaccaria
Copy link
Contributor

Issue link

What changes have been made

Display KubeRay parameter in release workflow and check for the existence of the chosen KubeRay release.

Previously the KubeRay parameter was not displayed
image

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

if [[ "$status_code" == "200" ]]; then
echo "KubeRay release with version ${{ github.event.inputs.mcad-version }} exists and available to use."
fi
echo "KubeRay release with version ${{ github.event.inputs.kuberay-version }} does not exist. Please select an existing version."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure that the step fails in case KubeRay version is not available?

@sutaakar
Copy link
Contributor

@ChristianZaccaria Thinking about usage of Check if KubeRay release exists.
Should it be just informative or should it be considered as a prerequisite of the release?

@ChristianZaccaria
Copy link
Contributor Author

@ChristianZaccaria Thinking about usage of Check if KubeRay release exists. Should it be just informative or should it be considered as a prerequisite of the release?

I think in this case we will always want to specify an existing version of KubeRay to ensure the compatibility matrix is updated to the correct version we have tested. Inputting a non existing version in the matrix could cause confusion. What do you think?

@sutaakar
Copy link
Contributor

In such case it may be good to fail whole pipeline in case KubeRay version is not valid.
Can you adjust other steps to require this new step to pass first before being triggered?

@ChristianZaccaria
Copy link
Contributor Author

I added that check now. I think we don't really require the check-kuberay-version to be triggered for instascale or codeflare-operator as the other components will need to pass first. Should I keep the check or remove them from instascale and CFO?

@sutaakar
Copy link
Contributor

You can remove it from InstaScale and operator

@ChristianZaccaria
Copy link
Contributor Author

Updated, I think it's good to go. Thanks Karel

@sutaakar
Copy link
Contributor

One nitpick above,otherwise looks fine.

@ChristianZaccaria
Copy link
Contributor Author

Thanks good catch!

Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6b5acfc into project-codeflare:main Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants