-
Notifications
You must be signed in to change notification settings - Fork 61
Display input for KubeRay parameter and check for existence #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display input for KubeRay parameter and check for existence #478
Conversation
if [[ "$status_code" == "200" ]]; then | ||
echo "KubeRay release with version ${{ github.event.inputs.mcad-version }} exists and available to use." | ||
fi | ||
echo "KubeRay release with version ${{ github.event.inputs.kuberay-version }} does not exist. Please select an existing version." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make sure that the step fails in case KubeRay version is not available?
034d610
to
c43e19e
Compare
@ChristianZaccaria Thinking about usage of |
I think in this case we will always want to specify an existing version of KubeRay to ensure the compatibility matrix is updated to the correct version we have tested. Inputting a non existing version in the matrix could cause confusion. What do you think? |
In such case it may be good to fail whole pipeline in case KubeRay version is not valid. |
c43e19e
to
b318348
Compare
I added that check now. I think we don't really require the |
You can remove it from InstaScale and operator |
b318348
to
de6d084
Compare
Updated, I think it's good to go. Thanks Karel |
One nitpick above,otherwise looks fine. |
de6d084
to
ee487e6
Compare
Thanks good catch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
What changes have been made
Display KubeRay parameter in release workflow and check for the existence of the chosen KubeRay release.
Previously the KubeRay parameter was not displayed

Verification steps
Checks