Skip to content

Prepare Pytorch MNIST test image for disconnected testing #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Feb 14, 2024

Issue link

RHOAIENG-2617

What changes have been made

Generating MNIST test job image to be used in e2e tests. This image doesn't need any external dependency.
Tests adjustments will follow once this PR is merged and image is built and pushed.

Serves as a replacement for https://quay.io/repository/project-codeflare/mnist-job-test?tab=tags version 0.0.1

Verification steps

Test it manually using make image-mnist-job-test-push.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@sutaakar sutaakar requested review from astefanutti and removed request for ChristianZaccaria and jbusche February 14, 2024 14:13
@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Feb 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d0274d0 into project-codeflare:main Feb 15, 2024
@sutaakar sutaakar deleted the mnist-job branch February 15, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants