Skip to content

Add completion status for TestMNISTPyTorchMCAD #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Nov 29, 2023

Issue link

N/A
Waiting for project-codeflare/codeflare-common#17

What changes have been made

Add AppWrapper completion status for TestMNISTPyTorchMCAD.

Verification steps

N/A
To be checked by PR check.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@sutaakar sutaakar marked this pull request as ready for review November 30, 2023 10:47
@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 23bffcc into project-codeflare:main Nov 30, 2023
@sutaakar sutaakar deleted the completion-status branch November 30, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants