Skip to content

Copying MCAD CRDs in Kustomize config instead of referencing them #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 20, 2023
Merged

Copying MCAD CRDs in Kustomize config instead of referencing them #357

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fd00167
copying mcad crds in kustomize config instead of referencing them
Fiona-Waters Oct 19, 2023
07f6abf
addressing feedback
Fiona-Waters Oct 19, 2023
81400ae
build: split crds into their own files
dimakis Oct 20, 2023
2dffc9e
refactor: isntall yq if not exists
dimakis Oct 20, 2023
b2966ee
updating kustomization.yaml and verify_generated_files workflow
Fiona-Waters Oct 20, 2023
80835d3
remove restore
Fiona-Waters Oct 20, 2023
72524ca
adding crds
Fiona-Waters Oct 20, 2023
e1f3759
update check_yq target
Fiona-Waters Oct 20, 2023
79159cd
Update Makefile
dimakis Oct 20, 2023
29d544e
Update Makefile
dimakis Oct 20, 2023
f6fdbc3
Update Makefile
dimakis Oct 20, 2023
97efe89
commenting out lines
Fiona-Waters Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,10 @@ defaults:
gofmt -w $(DEFAULTS_TEST_FILE)

.PHONY: manifests
manifests: controller-gen ## Generate RBAC objects.
manifests: controller-gen kustomize ## Generate RBAC objects.
$(CONTROLLER_GEN) rbac:roleName=manager-role webhook paths="./..."
$(SED) -i -E "s|(- )\${MCAD_REPO}.*|\1\${MCAD_CRD}|" config/crd/mcad/kustomization.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too

$(KUSTOMIZE) build config/crd/mcad > config/crd/mcad.yaml

.PHONY: fmt
fmt: ## Run go fmt against code.
Expand Down
4 changes: 2 additions & 2 deletions config/crd/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This kustomization.yaml is not intended to be run by itself,
# since it depends on service name and namespace that are out of this kustomize package.
# It should be run by config/default
resources:
- mcad
#resources:

#+kubebuilder:scaffold:crdkustomizeresource
Loading