Skip to content

fix: remove ServiceAccount binding to the edit role #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2023
Merged

fix: remove ServiceAccount binding to the edit role #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9762026
fix: remove ServiceAccount binding to the edit role
VanillaSpoon Oct 3, 2023
aa18a41
add: batch permissions
VanillaSpoon Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions config/rbac/edit_role_binding.yaml
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion config/rbac/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,5 @@ resources:
- role_binding.yaml
- instascale_role.yaml
- instascale_role_binding.yaml
- edit_role_binding.yaml # We are using this binding as mcad requires this role
- leader_election_role.yaml
- leader_election_role_binding.yaml
11 changes: 11 additions & 0 deletions config/rbac/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,17 @@ rules:
- patch
- update
- watch
- apiGroups:
- batch
resources:
- jobs
verbs:
- create
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While that works, MCAD should theoretically also be able to update these resources, so I'd suggest to add the following verbs for consistency:

- patch
- update
- watch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @astefanutti :) I have applied the update in aa18a41

- delete
- list
- patch
- update
- watch
- apiGroups:
- apps
resources:
Expand Down