Skip to content

[262] Add links to other release notes #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jiripetrlik
Copy link
Contributor

@jiripetrlik jiripetrlik commented Sep 14, 2023

Issue link

Closes #262

Tested in https://github.com/jiripetrlik/codeflare-operator/actions/runs/6184331678/job/16787779852 . However, I removed all not necessary steps.

@jiripetrlik jiripetrlik requested review from sutaakar and removed request for MichaelClifford and dimakis September 14, 2023 08:34
@@ -84,6 +84,13 @@ jobs:
run: make install-operator-sdk

- name: Adjust Compatibility Matrix in readme
run: |
sed -i -E "s/(.*CodeFlare Operator.*)v[0-9]+\.[0-9]+\.[0-9]+(.*\|.*\|)/\1${{ github.event.inputs.version }}\2/" README.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need for the regex alteration.
If you call the regex below twice it will replace both values.
Not sure if there is a possibility to do both replacements in one command.

Copy link
Contributor

@KPostOffice KPostOffice Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sed -i -E "s/(.*CodeFlare Operator.*)v[0-9]+\.[0-9]+\.[0-9]+(.*)v[0-9]+\.[0-9]+\.[0-9]+(.*)/\1${{ github.event.inputs.version }}\2${{ github.event.inputs.version }}\3/" README.md

Single line sed, I tested this in my local repo and it seems to work well.

@sutaakar
Copy link
Contributor

Thinking whether it would have sense to put the link directly into the version value in readme instead of extra column, though I don't have a strong opinion on that.

@jiripetrlik jiripetrlik force-pushed the 262-link-other-release-notes branch from 7b0a97a to fb62e43 Compare September 18, 2023 07:48
@jiripetrlik jiripetrlik force-pushed the 262-link-other-release-notes branch from fb62e43 to 51b2d25 Compare September 18, 2023 14:04
@jiripetrlik
Copy link
Contributor Author

@sutaakar @KPostOffice
Thank you for valuable comments. It should be changed. Test run can be found here: https://github.com/jiripetrlik/codeflare-operator/actions/runs/6223842551/job/16890708698

@anishasthana
Copy link
Contributor

/retest

@sutaakar
Copy link
Contributor

/lgtm

@sutaakar
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9b2d77c into project-codeflare:main Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project CodeFlare Release Action to link to other release notes
5 participants