-
Notifications
You must be signed in to change notification settings - Fork 61
[262] Add links to other release notes #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[262] Add links to other release notes #287
Conversation
.github/workflows/tag-and-build.yml
Outdated
@@ -84,6 +84,13 @@ jobs: | |||
run: make install-operator-sdk | |||
|
|||
- name: Adjust Compatibility Matrix in readme | |||
run: | | |||
sed -i -E "s/(.*CodeFlare Operator.*)v[0-9]+\.[0-9]+\.[0-9]+(.*\|.*\|)/\1${{ github.event.inputs.version }}\2/" README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need for the regex alteration.
If you call the regex below twice it will replace both values.
Not sure if there is a possibility to do both replacements in one command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sed -i -E "s/(.*CodeFlare Operator.*)v[0-9]+\.[0-9]+\.[0-9]+(.*)v[0-9]+\.[0-9]+\.[0-9]+(.*)/\1${{ github.event.inputs.version }}\2${{ github.event.inputs.version }}\3/" README.md
Single line sed, I tested this in my local repo and it seems to work well.
Thinking whether it would have sense to put the link directly into the version value in readme instead of extra column, though I don't have a strong opinion on that. |
7b0a97a
to
fb62e43
Compare
fb62e43
to
51b2d25
Compare
@sutaakar @KPostOffice |
/retest |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
Closes #262
Tested in https://github.com/jiripetrlik/codeflare-operator/actions/runs/6184331678/job/16787779852 . However, I removed all not necessary steps.