Skip to content

adjust rbac to match mcad #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from
Closed

adjust rbac to match mcad #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
5ae13d1
adjust rbac to match mcad
jbusche Aug 17, 2023
dcac680
revert go.mod and go.sum
jbusche Aug 17, 2023
67d902d
regenerate of role
jbusche Aug 17, 2023
1e3f7dc
more info on make manifests
jbusche Aug 17, 2023
c62b9b2
Apply MCAD CRD version replace for operator uninstall and undeploy
sutaakar Aug 15, 2023
3eeb618
Test support: return default status if Route is not initialized
sutaakar Aug 17, 2023
fd58cf7
Test support: return error if Ray API response code doesn't match
sutaakar Aug 22, 2023
50ccd1a
Test support: Return WriteRayJobLogs function
sutaakar Aug 23, 2023
be418f7
build(deps): bump github.com/onsi/gomega from 1.27.8 to 1.27.10
dependabot[bot] Aug 10, 2023
e9e4b85
Update dependency versions for release v0.2.0
anishasthana Aug 29, 2023
4d1e0b4
Automatically label issues as needing triage and add them to project …
anishasthana Aug 25, 2023
004d0e9
Fixing instascale version
Fiona-Waters Aug 30, 2023
ed54c77
Update dependency versions for release v0.2.2
anishasthana Aug 30, 2023
652510f
e2e tests: Reduce CPU requests for e2e test AppWrappers
sutaakar Aug 31, 2023
a0f7e7c
Change remaining is-latest references to stable
anishasthana Aug 30, 2023
e3c3114
Release workflow - replace any version value in Makefile
sutaakar Sep 1, 2023
02e7425
Remove custom-metrics-api
ChristianZaccaria Sep 4, 2023
a4eb235
Move AppWrapper API to workload.codeflare.dev group
astefanutti Aug 25, 2023
a204198
adjust rbac to match mcad
jbusche Aug 17, 2023
e5d10a7
revert go.mod and go.sum
jbusche Aug 17, 2023
578d891
Merge branch 'main' into jb-187-quotatree
jbusche Sep 5, 2023
de7ed65
config/rbac/role.yaml
jbusche Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ The code for MCAD/InstaScale resource reconcilliation can be found in the `contr
- See `mcad_controller.go` and `instascale_controller.go`

## Building and Deployment
If changes are made in the `api` dir, run: `make manifests`
If changes are made in the `api` dir, or to regenerate config after go code changes, run: `make manifests`
- This will generate new CRDs and associated files

If changes are made to any Go code (like in the `controllers` dir for example), run: `make`
Expand Down
2 changes: 2 additions & 0 deletions config/rbac/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,9 @@ rules:
- appwrappers/finalizers
- appwrappers/status
- queuejobs
- quotasubtrees
- schedulingspecs
- xqueuejobs
verbs:
- create
- delete
Expand Down
2 changes: 1 addition & 1 deletion controllers/mcad_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func (r *MCADReconciler) DeleteResource(params *MCADParams, template string, fns
// +kubebuilder:rbac:groups=codeflare.codeflare.dev,resources=mcads,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups=codeflare.codeflare.dev,resources=mcads/status,verbs=get;update;patch
// +kubebuilder:rbac:groups=codeflare.codeflare.dev,resources=mcads/finalizers,verbs=update
// +kubebuilder:rbac:groups=workload.codeflare.dev,resources=queuejobs;schedulingspecs;appwrappers;appwrappers/finalizers;appwrappers/status,verbs=get;list;watch;create;update;patch;delete;deletecollection
// +kubebuilder:rbac:groups=workload.codeflare.dev,resources=xqueuejobs;queuejobs;schedulingspecs;appwrappers;appwrappers/finalizers;appwrappers/status;quotasubtrees,verbs=get;list;watch;create;update;patch;delete;deletecollection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think xqueuejobs CRD has been removed from recent MCAD versions.

// +kubebuilder:rbac:groups=core,resources=pods;lists;namespaces,verbs=get;list;watch;create;update;patch;delete;deletecollection
// +kubebuilder:rbac:groups=core,resources=bindings;pods/binding,verbs=create
// +kubebuilder:rbac:groups=core,resources=kube-scheduler,verbs=get;update
Expand Down