Added unitest for support-package #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
sutaakar
reviewed
Jan 4, 2024
sutaakar
reviewed
Jan 4, 2024
sutaakar
reviewed
Jan 4, 2024
sutaakar
reviewed
Jan 4, 2024
sutaakar
reviewed
Jan 4, 2024
sutaakar
reviewed
Jan 4, 2024
sutaakar
reviewed
Jan 4, 2024
sutaakar
reviewed
Jan 4, 2024
sutaakar
reviewed
Jan 4, 2024
sutaakar
reviewed
Jan 4, 2024
sutaakar
reviewed
Jan 4, 2024
sutaakar
reviewed
Jan 4, 2024
sutaakar
reviewed
Jan 4, 2024
sutaakar
reviewed
Jan 4, 2024
support/fakeclient.go
Outdated
| "k8s.io/client-go/kubernetes/fake" | ||
| ) | ||
|
|
||
| func NewFakeKubeClientWithObjects(objects ...runtime.Object) *fake.Clientset { |
There was a problem hiding this comment.
I see a common usage to initialize client using for example:
fakeClient := NewFakeKubeClientWithObjects(fakeIngress...)
test := With(t).(*T)
test.client = &testClient{
core: fakeClient,
}
Wouldn't it have sense to add it here and return test?
There was a problem hiding this comment.
Resolved as per suggestion
Raghul-M
force-pushed
the
unittest-239
branch
2 times, most recently
from
cf0a92d to
253f773
Compare
sutaakar
reviewed
Jan 8, 2024
sutaakar
reviewed
Jan 8, 2024
Raghul-M
force-pushed
the
unittest-239
branch
2 times, most recently
from
660a53e to
171bb35
Compare
sutaakar
reviewed
Jan 8, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raghul-M, sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
Closes project-codeflare/codeflare-operator#239
What changes have been made
Added Unit test for the Support Package Applicable Modules
Added Workflow file to test the Unit tests
Verification steps
RUN -
go test ./support -vChecks