Skip to content

Disable component-level failure detection for Ray #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Disable component-level failure detection for Ray #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions internal/controller/appwrapper/appwrapper_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,10 @@ func (r *AppWrapperReconciler) getComponentStatus(ctx context.Context, aw *workl
if obj.GetDeletionTimestamp().IsZero() {
summary.deployed += 1

/* Disabled because failed is not a terminal state.
* We've observed RC transiently entering "failed" before becoming "ready" due to ingress not being ready
* TODO: Explore fixing in upstream projects.

// RayCluster is failed if status.State is "failed"
status, ok := obj.UnstructuredContent()["status"]
if !ok {
Expand All @@ -595,6 +599,7 @@ func (r *AppWrapperReconciler) getComponentStatus(ctx context.Context, aw *workl
if state.(string) == "failed" {
summary.failed += 1
}
*/
}
} else if !apierrors.IsNotFound(err) {
return nil, err
Expand All @@ -608,6 +613,9 @@ func (r *AppWrapperReconciler) getComponentStatus(ctx context.Context, aw *workl
if obj.GetDeletionTimestamp().IsZero() {
summary.deployed += 1

/* Disabled because we are not sure if failed is a terminal state.
* TODO: Determine whether or not RayJob has the same issue as RayCluster

// RayJob is failed if status.jobsStatus is "FAILED"
status, ok := obj.UnstructuredContent()["status"]
if !ok {
Expand All @@ -620,6 +628,7 @@ func (r *AppWrapperReconciler) getComponentStatus(ctx context.Context, aw *workl
if jobStatus.(string) == "FAILED" {
summary.failed += 1
}
*/
}
} else if !apierrors.IsNotFound(err) {
return nil, err
Expand Down