Skip to content

WIP - Mixed content error for Issue #543 #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2018

Conversation

jareddonovan
Copy link
Contributor

Before your pull request is reviewed and merged, please ensure that:

  • there are no linting errors -- npm run lint
  • your code is in a uniquely-named feature branch and has been rebased on top of the latest master. If you're asked to make more changes, make sure you rebase onto master then too!
  • your pull request is descriptively named and links to an issue number, i.e. Fixes #123

This is a work in progress for issue #543. There are two changes:

  • Adding a config for Express to trust the proxy so that the https protocol is correctly used in the
    base tag.
  • Fix the replacement of paths for links in scripts.

These probably aren't ready to merge, just posting so others can see my progress and put me on the right path :).

@catarak
Copy link
Member

catarak commented Jul 3, 2018

This seems to be working locally for me. I'm gonna merge this, and if it's not working in prod, revert it.

@catarak catarak merged commit 903713e into processing:master Jul 3, 2018
@catarak
Copy link
Member

catarak commented Jul 3, 2018

UPDATE: that didn't fix it 😄

@catarak
Copy link
Member

catarak commented Jul 3, 2018

I noticed that the base url is being generated differently server-side (https://github.com/processing/p5.js-web-editor/blob/master/server/controllers/embed.controller.js#L27), which would affect the /full/ view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants