Fix needs saving mark for renamed: Fixes #576

[jareddonovan]

Before your pull request is reviewed and merged, please ensure that:

• there are no linting errors -- npm run lint (there are linting errors, but not in the files I have touched.)
• your code is in a uniquely-named feature branch and has been rebased on top of the latest master. If you're asked to make more changes, make sure you rebase onto master then too!
• your pull request is descriptively named and links to an issue number, i.e. Fixes #576

This is an attempt at fixing the problem described in #576, which is that after a file in a project has been renamed, the 'needs-saving' marker is not cleared after saving. I'm mainly adding this pull request to show that it fixes the problem, but I don't think it's the best code. If I was more familiar with the lodash library, I would try and use one of the functions provided by that rather than writing my own custom comparison function.

Another option is to look at the parts of the code that set the 'isEditingName' and 'isOptionsOpen' properties after files have been renamed. These are the properties that cause the comparision between the local copy of the project and that returned by the server to be different.

[shinytang6]

Hi @awarua , I took a quick look and I thought the problem lies in line 47 in project.controller.js. It seems that findByIdAndUpdate can't add new fields(here isEditingName and isOptionsOpen) into database. Maybe isEditingName and isOptionsOpen should be added to fileSchema or just remove these properties before we compare currentState.files withresponse.data.files ? Welcome discussion :)

[catarak]

thanks for your work on this, @shinytang6 and @awarua. i think a long term solution for this would be to separate certain parts of the file state into React and leave certain parts in Redux, or maybe follow @shinytang6's solution. when i started working on this project, i wasn't too familiar with react or redux, and didn't realize you didn't have to put the whole state into redux.

[jareddonovan]

Thanks @catarak and @shinytang6. I'll have another go at this on the weekend. I'll probably take an attempt at @shinytang6's solution but will see if I can figure out enough about react/redux to implement what you describe too @catarak.

[catarak]

feel free to submit a WIP (work in progress) PR and ask questions!