-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Adding User Settings View #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
return Promise.resolve(true).then(() => {}); | ||
} | ||
|
||
function validate(formProps) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since login/signup use the same regexes to do validation, it probably makes sense to set them to some other variable in another file and import them. I've played around with the idea of converting the constants.js
file to a folder called constants
, then changing constants.js
to actiontypes.js
, and then, more constant files can be added as necessary. Or maybe there's a better place to put this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I put the validate function into utils/reduxFormUtils.js
Thank you! I just fixed the |
Fixes #248
This pull request -
My account
to the upper-right user menuMy account
page withusername
,email
,currentPassword
, andnewPassword
.username
andemail
are in use, if thecurrentPassword
is valid, and ifnew password
is not empty whencurrentPassword
is not empty. If yes, update all user settings.