Skip to content

Adding User Settings View #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 16, 2017
Merged

Conversation

yining1023
Copy link
Member

@yining1023 yining1023 commented Mar 16, 2017

Fixes #248

This pull request -

  • adds My account to the upper-right user menu
  • creates a My account page with username, email, currentPassword, and newPassword.
  • checks if the username and email are in use, if the currentPassword is valid, and if new password is not empty when currentPassword is not empty. If yes, update all user settings.
    screen shot 2017-03-15 at 10 51 24 pmscreen shot 2017-03-15 at 10 49 03 pmscreen shot 2017-03-15 at 11 13 44 pmscreen shot 2017-03-15 at 11 09 48 pm

return Promise.resolve(true).then(() => {});
}

function validate(formProps) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since login/signup use the same regexes to do validation, it probably makes sense to set them to some other variable in another file and import them. I've played around with the idea of converting the constants.js file to a folder called constants, then changing constants.js to actiontypes.js, and then, more constant files can be added as necessary. Or maybe there's a better place to put this file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I put the validate function into utils/reduxFormUtils.js

@catarak
Copy link
Member

catarak commented Mar 16, 2017

this looks great, you killed it 💃

I noticed that the dropdown styling is a little funky... Log Out has some extra padding to the left and is a different color/has a different hover state. You mind matching it to the other two dropdown items?
screen shot 2017-03-16 at 1 26 16 am

@yining1023
Copy link
Member Author

Thank you!☺️

I just fixed the Log out button style.

@catarak catarak merged commit fe6acc9 into processing:master Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants