Force HTTPS redirection for log in and sign up #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, no redirection occurs if sourceProtocol is not explicitly defined.
The flag is set to `false` on all projects and as the UI has no way to change this, it always redirects to HTTP after a signup/login action.
|
🎉 🎉 🎉 |
andrewn
changed the title
Will log to the browser console any redirection that would have happened. Added a line in the README about how to enable this for testing in development.
andrewn
changed the title
|
I think this is finally ready for review!
|
|
woohoo this looks great AND works great! this is definitely territory for a new issue/PR, but I just realized that we'll need to do some pushing/popping of the redux state into localStorage, i.e. if a user is not logged in and starts working on a sketch, they have to log in to save it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements client-side redirection to HTTPS of the
/signup,/loginand/reset-passwordviews described in #139. If that view is mounted and is not on HTTPS then it's redirected, causing the app to reload.New projects are created with a
serveSecure: falseflag. After sign-up/log-in/reset, this flag is used to decide which protocol to redirect back to.serveSecuredefaults tofalse. Until some user-facing UI switch is built (see #170) then it will always redirect back to HTTP.