Skip to content

Upgrade Asset Modules #3155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

PiyushChandra17
Copy link
Contributor

Fixes #2023

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@raclim raclim added Priority:High Should be addressed soon but not critical Type:Task Tasks tied specifically to developer operations and maintenance labels Jun 13, 2024
@raclim
Copy link
Collaborator

raclim commented Jun 14, 2024

Thanks for your work on this! Since there's currently an open PR (#2957) for this issue at the moment, I think we might stick with that one to resolve it. I'm sorry that we couldn't get this one in, but will check out the other ones you've raised!

@raclim raclim closed this Jun 14, 2024
@PiyushChandra17
Copy link
Contributor Author

PiyushChandra17 commented Jun 15, 2024

@raclim I think this PR is up to date one with context with the latest webpack version, also i have gone through the webpack docs here.

Made the following changes:

  • npm installed latest webpack version
  • npm uninstalled file-loader, raw-loader
  • replaced file-loader with asset/resource
  • replaced raw-loader with asset/source
  • added generator following the docs
  • Used hash version in production, i think that's what the docs states

PS: If this goes well, i can reopen this PR in future i guess else we can stick the existing one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High Should be addressed soon but not critical Type:Task Tasks tied specifically to developer operations and maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Webpack to use Asset Modules
2 participants