Skip to content

fix: SignUp page t&c-line japanese translation fixed. #3135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2024

Conversation

nishikant23
Copy link
Contributor

What this PR do?
It translates the t&c-line of signup page into japanese under japanese-language selection

Fixes #3102

Changes Made:
Original Page:
b4

After changes :

p5jsAfterChange.mp4

I have verified that this pull request:

  • is run on docker and tested on localhost:8000
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

welcome bot commented May 25, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nishikant23 and @3ru for your work and input on this! Since this matches the suggested changes, I'm going to go ahead with merging this in!

@raclim raclim merged commit 2294661 into processing:develop May 31, 2024
1 check passed
@nishikant23 nishikant23 deleted the fix/japanese_translation branch June 1, 2024 09:35
@nishikant23
Copy link
Contributor Author

@raclim thanks for merging my PR & thanks @3ru for suggestion to improvised my translation text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: The t&c line of signup page for japanese language is still in english.
3 participants