Skip to content

Updated passport handles expected errors as exceptions #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Kuldeep246
Copy link

@Kuldeep246 Kuldeep246 commented Feb 23, 2024

Added error messages in the third argument of the done callback instead of the first argument in Google and Github sign in features

Fixes #issue-number

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

…tions

Added error messages in the third argument of the done callback instead of the first argument with Google and Github sign in features
Copy link

welcome bot commented Feb 23, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

Copy link

release-com bot commented Feb 23, 2024

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-439bd40bdf

@Kuldeep246 Kuldeep246 changed the title issue-#3044 Added passport handles expected errors as exceptions Updated passport handles expected errors as exceptions Feb 23, 2024
Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has some formatting errors which can be fixed by running the lint command.

Comment on lines +16 to +18
const accountLinkingErrorMessage =
'Account is already linked to another account.';

Copy link
Collaborator

@lindapaiste lindapaiste Feb 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this. I'm going to close this PR and go with #3050 instead because I don't like this particular change. IMO we want to keep the name of the service in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants