-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Centralised Breakpoints using useIsMobile hook #3042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
raclim
merged 4 commits into
processing:develop
from
Keshav-0907:centralising-breakpoints
Mar 29, 2024
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
93fd554
Centralised Breakpoints
Keshav-0907 f78ca67
Merge branch 'develop' into centralising-breakpoints
Keshav-0907 3232034
Merge branch 'develop' into centralising-breakpoints
raclim 5486751
Merge branch 'develop' into centralising-breakpoints
raclim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,22 @@ | ||
import React from 'react'; | ||
import PropTypes from 'prop-types'; | ||
import { useSelector } from 'react-redux'; | ||
import MediaQuery from 'react-responsive'; | ||
import useIsMobile from '../../hooks/useIsMobile'; | ||
|
||
import Nav from './Nav'; | ||
import Toolbar from './Toolbar'; | ||
|
||
const Header = (props) => { | ||
const project = useSelector((state) => state.project); | ||
|
||
const isMobile = useIsMobile(); | ||
|
||
return ( | ||
<header> | ||
<Nav /> | ||
<MediaQuery minWidth={770}> | ||
{(matches) => { | ||
if (matches) | ||
return ( | ||
<Toolbar | ||
syncFileContent={props.syncFileContent} | ||
key={project.id} | ||
/> | ||
); | ||
return null; | ||
}} | ||
</MediaQuery> | ||
{!isMobile && ( | ||
<Toolbar syncFileContent={props.syncFileContent} key={project.id} /> | ||
)} | ||
Comment on lines
+17
to
+19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So much cleaner! |
||
</header> | ||
); | ||
}; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import { useMediaQuery } from 'react-responsive'; | ||
|
||
const useIsMobile = (customBreakpoint) => { | ||
const breakPoint = customBreakpoint || 770; | ||
const isMobile = useMediaQuery({ maxWidth: breakPoint }); | ||
return isMobile; | ||
}; | ||
|
||
export default useIsMobile; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at these lines you can see why this PR is so important! The other components with
MediaQuery
are usingminWidth={770}
. I wrote the code on the left and usedmaxWidth: 770
. But it should have beenmaxWidth: 669
so that it looks right when the screen is exactly 770px wide.