Skip to content

Partial Fixed: Mobile responsiveness of find and replace dialog box #2854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Partial Fixed: Mobile responsiveness of find and replace dialog box #2854

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10f11a9
Partial fix mobile responsiveness of find and replace dialog box
mrkirthi-24 Jan 6, 2024
2ae6c09
Update editor.scss
mrkirthi-24 Jan 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions client/styles/components/_editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ pre.CodeMirror-line {
}
// left: 0 !important;
width: #{48 / $base-font-size}rem;
z-index: 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't need an explicit z-index here.

It looks like there's a z-index: 4 on the .CodeMirror-gutter-wrapper div which is coming from the core CodeMirror library. I assume it's there for a reason so let's not mess with it.

}

/*
Expand All @@ -96,6 +97,7 @@ pre.CodeMirror-line {
right: 0;
width: 100%;
margin-left: 0;
z-index: 5;
}

z-index: 1;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the existing z-index: 1 (line 101) to z-index: 5, regardless of breakpoint. Like it's not an issue on larger screens because the dialog doesn't overlap the gutter, but it does seem "right" that it should have a higher z-index.

Expand Down Expand Up @@ -139,6 +141,10 @@ pre.CodeMirror-line {
.CodeMirror-find-controls {
display: flex;
align-items: center;

@media (max-width: 580px) {
padding: 0.6rem 0rem;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unrelated to the z-index issues. So let's save that for a PR where we fix the layout.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will raise a new pr for it. Thank you

}
.CodeMirror-search-inputs {
width: 30%;
Expand Down