Skip to content

Fixed: Translation of T&C on SignUp page #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 6, 2024
Merged

Fixed: Translation of T&C on SignUp page #2847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5e9ed4
Fixed: Translation of T&C on SignUp page
harmanbatheja15 Jan 6, 2024
604f609
Added Hindi Translation for T&C on SignUp page
harmanbatheja15 Jan 6, 2024
39da50a
Merge branch 'develop' into fixed-translation-on-SignUp-page
harmanbatheja15 Jan 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions client/modules/User/pages/SignupView.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';
import { Link } from 'react-router-dom';
import { Helmet } from 'react-helmet';
import { useTranslation } from 'react-i18next';
import { useTranslation, Trans } from 'react-i18next';
import SignupForm from '../components/SignupForm';
import SocialAuthButton from '../components/SocialAuthButton';
import Nav from '../../IDE/components/Header/Nav';
Expand All @@ -27,9 +27,13 @@ function SignupView() {
<SocialAuthButton service={SocialAuthButton.services.google} />
</div>
<p className="form__navigation-options">
By signing up, you agree to the p5.js Editor&apos;s{' '}
<Link to="/terms-of-use">Terms of Use</Link> and{' '}
<Link to="/privacy-policy">Privacy Policy</Link>.
<Trans
i18nKey="SignupView.Warning"
components={[
<Link to="/terms-of-use">Terms of use</Link>,
<Link to="/privacy-policy">Privacy Policy</Link>
]}
/>
</p>
<p className="form__navigation-options">
{t('SignupView.AlreadyHave')}{' '}
Expand Down
3 changes: 2 additions & 1 deletion translations/locales/en-US/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,8 @@
"Description": "Sign Up",
"Or": "Or",
"AlreadyHave": "Already have an account?",
"Login": "Log In"
"Login": "Log In",
"Warning": "By signing up, you agree to the p5.js Editor's <0>Terms of Use</0> and <1>Privacy Policy.</1>"
},
"EmailVerificationView": {
"Title": "p5.js Web Editor | Email Verification",
Expand Down
3 changes: 2 additions & 1 deletion translations/locales/hi/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,8 @@
"Description": "साइन अप",
"Or": "या",
"AlreadyHave": "पहले से ही अकाउंट है?",
"Login": "लॉग इन"
"Login": "लॉग इन",
"Warning": "साइन अप करके, आप p5.js संपादक की उपयोग की <0>शर्तों</0> और <1>गोपनीयता नीति</1> से सहमत होते हैं।"
},
"EmailVerificationView": {
"Title": "p5.js वेब एडिटर | ईमेल वेरीफिकेशन",
Expand Down