Skip to content

Feature/enhancement of pink buttons #2826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Mubashirshariq
Copy link
Contributor

Fixes #2823

Changes:
1)changed the colour of solid pink button on hovering to p5jsActivePink
2)Added a new darkish yellow colour as p5jsActiveYellow
3)changed the colour of solid yellow button on hovering to p5jsActiveYellow in contrast theme

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good 👍 The shade of yellow might be a bit too dark? I'll compare it with the one in #2827 and see if one better than the other.

In the future please make sure that you start a new branch from develop when working on a different feature so that you don't include commits from your other PRs.

In this case your other PR was good to go so I merged that one into develop which means that those files don't show up as changes anymore.

@Mubashirshariq
Copy link
Contributor Author

@lindapaiste sure thanks for the feedback

@lindapaiste lindapaiste added the Area:CSS For styling or layout issues handled with CSS/SASS label Jan 9, 2024
@raclim
Copy link
Collaborator

raclim commented Jun 5, 2024

Thanks for your work on this! I ultimately merged in #2883 to address this issue, so I'm going to close this one! I'm sorry that we couldn't get this in, but please feel free to check out our other issues, thanks again!

@raclim raclim closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:CSS For styling or layout issues handled with CSS/SASS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solid pink buttons need a hover effect
3 participants