Skip to content

Fix keyboard shortcut modal's width for mobile devices #2819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Sanjay-Sahu-Bandla
Copy link

Issue:

The Keyboard Shortcuts modal exhibited horizontal scrolling on mobile devices due to a fixed width.

Solution:

Resolved by adjusting the modal's width property from a fixed value to max-width, enabling responsiveness based on content. This ensures optimal viewing on various screen sizes, enhancing user experience.

Changes:

Before

keyboard-shortcuts-before

After

keyboard-shortcuts-after

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.

Copy link

welcome bot commented Jan 1, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@lindapaiste
Copy link
Collaborator

lindapaiste commented Jan 1, 2024

Both this and #2817 have the same effect on the desktop size. It makes it go to an auto width so the modal becomes a little bit skinner than the current view. I'm going to close this PR and work with #2817 as that one was submitted first.

@lindapaiste lindapaiste closed this Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants