Skip to content

Fixed checkbox color (issue-#2808) #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Fixed checkbox color (issue-#2808) #2811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/styles/components/_toolbar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,6 @@
.checkbox__autorefresh{
cursor: pointer;
@include themify(){
color:getThemifyVariable('logo-color');
accent-color:getThemifyVariable('logo-color');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and it seems like this property has pretty good support: https://caniuse.com/mdn-css_properties_accent-color It's definitely working for me!

I'm wondering if we want some sort of fallback for older browsers which don't support accent-color. Like will the color setting work there or will it do nothing? I'm reading some articles and it seems like it would do nothing but I'm not sure. Do you know? (it's ok if you don't)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lindapaiste See, the color property is not working anywhere because it is not the property to change the color of a input checkbox ( as far as i know ). May be accent color will not work in some older browsers but color property will not work anywhere because it is not the property to change the color of a input checkbox. So its better to use accent color.
I run this code locally and in my browsers it works perfectly file... You can see that in the issue #2808 in expected behaviour.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok yeah I was wondering if there was an easy way to get backwards compatibility but it seems like there is not. So this looks good.

}
}