Update user.controller.js Fixing the error of ignoring the ERROR case… #2768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s by using return promise logic of JS.
|
Copying my comment from #2772 because this PR has the same issue. The changes to the function look good. You’ve changed the signature of the function so that it no longer accepts a callback as an argument. So you need to make sure that you have updated all the places where this function is used so that the work with an async/promise call instead of passing a callback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using return promise logic of JS to get the ERROR CASES fixed without ignoring like the current code does .
Fixes IGNORANCE OF ERROR CASES by adding return promise method .