Skip to content

fix: #2719 Shortcuts Ctrl + Shift + 1 and Ctrl + Shift + 2 aren't wor… #2720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 5, 2024
Merged

fix: #2719 Shortcuts Ctrl + Shift + 1 and Ctrl + Shift + 2 aren't wor… #2720

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
478f49d
fix: #2719 Shortcuts Ctrl + Shift + 1 and Ctrl + Shift + 2 aren't wor…
aryanas159 Dec 14, 2023
b287274
removed keymapping and used e.code instead
aryanas159 Dec 15, 2023
e0d3544
Merge branch 'develop' into issue-#2719
aryanas159 Dec 15, 2023
5ce9220
Merge branch 'develop' into issue-#2719
aryanas159 Dec 17, 2023
a032083
Merge branch 'develop' into issue-#2719
aryanas159 Dec 28, 2023
856b416
Merge branch 'develop' into issue-#2719
raclim Jun 5, 2024
695c039
revert back package-lock.json file
raclim Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion client/common/useKeyDownHandlers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,11 @@ export default function useKeyDownHandlers(keyHandlers) {
const isMac = navigator.userAgent.toLowerCase().indexOf('mac') !== -1;
const isCtrl = isMac ? e.metaKey : e.ctrlKey;
if (e.shiftKey && isCtrl) {
handlers.current[`ctrl-shift-${e.key.toLowerCase()}`]?.(e);
handlers.current[
`ctrl-shift-${
/^\d+$/.test(e.code.at(-1)) ? e.code.at(-1) : e.key.toLowerCase()
}`
]?.(e);
} else if (isCtrl) {
handlers.current[`ctrl-${e.key.toLowerCase()}`]?.(e);
}
Expand Down
Loading