Skip to content

My Staff List can now be read with dark mode on mobile devices. #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 24, 2023
Merged

My Staff List can now be read with dark mode on mobile devices. #2626

merged 3 commits into from
Nov 24, 2023

Conversation

shibomb
Copy link
Contributor

@shibomb shibomb commented Nov 21, 2023 •
edited
Loading

Fixes #2625

Changes:
The background color of each line of the staff list with dark mode on mobile devices has been set to a darker.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome Welcome
Copy link

welcome bot commented Nov 21, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@shibomb shibomb changed the title My Staff List can now be read on mobile devices. My Staff List can now be read with dark mode on mobile devices. Nov 21, 2023
@shibomb shibomb marked this pull request as ready for review November 21, 2023 17:46
lindapaiste
lindapaiste suggested changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Can you please apply this to the contrast theme too?

Just a note that we need to be careful when changing theme variables because they can be used in multiple places. In this case it seems like it's only used here so no issue.

@shibomb
The background color of each line of the staff list with "contrast mo…
3d0a274 
…de" on mobile devices has been set to a darker.

fixed  processing#2625
@shibomb
Copy link
Contributor Author

shibomb commented Nov 22, 2023

Thanks for reviewing!

I set the contrast theme value to "darker" ;-)
Could you re-review?

PiyushChandra17
PiyushChandra17 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@PiyushChandra17 PiyushChandra17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@shibomb shibomb requested a review from lindapaiste November 22, 2023 16:31
lindapaiste
lindapaiste approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌞 🌚

@lindapaiste lindapaiste merged commit 42dec8d into processing:develop Nov 24, 2023
@shibomb shibomb deleted the fix/readable-mystafflist-mobile branch November 24, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindapaiste lindapaiste lindapaiste approved these changes

@PiyushChandra17 PiyushChandra17 PiyushChandra17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

My Staff List (Sketches and Collections) are not readable with dark mode on Mobile Device
3 participants
@shibomb @lindapaiste @PiyushChandra17