Skip to content

fix crashing of app irrespective of aws s3 bucket set up #2610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 19, 2023
Merged

fix crashing of app irrespective of aws s3 bucket set up #2610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5658abd
fix crashing of app
PiyushChandra17 Nov 17, 2023
1d8b0f2
removed commented line console.error
PiyushChandra17 Nov 18, 2023
2b3dad1
Merge branch 'develop' into piyush/fix-app-crash
lindapaiste Nov 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 6 additions & 21 deletions client/modules/IDE/actions/collections.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,9 @@ export function getCollections(username) {
dispatch(stopLoader());
})
.catch((error) => {
const { response } = error;
dispatch({
type: ActionTypes.ERROR,
error: response.data
error: error?.response?.data
});
dispatch(stopLoader());
});
Expand Down Expand Up @@ -59,11 +58,9 @@ export function createCollection(collection) {
browserHistory.push(location);
})
.catch((error) => {
const { response } = error;
console.error('Error creating collection', response.data);
dispatch({
type: ActionTypes.ERROR,
error: response.data
error: error?.response?.data
});
dispatch(stopLoader());
});
Expand Down Expand Up @@ -91,14 +88,11 @@ export function addToCollection(collectionId, projectId) {
return response.data;
})
.catch((error) => {
const { response } = error;
dispatch({
type: ActionTypes.ERROR,
error: response.data
error: error?.response?.data
});
dispatch(stopLoader());

return response.data;
});
};
}
Expand All @@ -124,14 +118,11 @@ export function removeFromCollection(collectionId, projectId) {
return response.data;
})
.catch((error) => {
const { response } = error;
dispatch({
type: ActionTypes.ERROR,
error: response.data
error: error?.response?.data
});
dispatch(stopLoader());

return response.data;
});
};
}
Expand All @@ -149,13 +140,10 @@ export function editCollection(collectionId, { name, description }) {
return response.data;
})
.catch((error) => {
const { response } = error;
dispatch({
type: ActionTypes.ERROR,
error: response.data
error: error?.response?.data
});

return response.data;
});
};
}
Expand All @@ -174,13 +162,10 @@ export function deleteCollection(collectionId) {
return response.data;
})
.catch((error) => {
const { response } = error;
dispatch({
type: ActionTypes.ERROR,
error: response.data
error: error?.response?.data
});

return response.data;
});
};
}
3 changes: 1 addition & 2 deletions client/modules/IDE/actions/preferences.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@ function updatePreferences(formParams, dispatch) {
.put('/preferences', formParams)
.then(() => {})
.catch((error) => {
const { response } = error;
dispatch({
type: ActionTypes.ERROR,
error: response.data
error: error?.response?.data
});
});
}
Expand Down
9 changes: 3 additions & 6 deletions client/modules/IDE/actions/project.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,9 @@ export function getProject(id, username) {
dispatch(setUnsavedChanges(false));
})
.catch((error) => {
const { response } = error;
dispatch({
type: ActionTypes.ERROR,
error: response.data
error: error?.response?.data
});
});
};
Expand Down Expand Up @@ -338,10 +337,9 @@ export function cloneProject(project) {
dispatch(setNewProject(response.data));
})
.catch((error) => {
const { response } = error;
dispatch({
type: ActionTypes.PROJECT_SAVE_FAIL,
error: response.data
error: error?.response?.data
});
});
}
Expand Down Expand Up @@ -376,10 +374,9 @@ export function changeProjectName(id, newName) {
}
})
.catch((error) => {
const { response } = error;
dispatch({
type: ActionTypes.PROJECT_SAVE_FAIL,
error: response.data
error: error?.response?.data
});
});
};
Expand Down
3 changes: 1 addition & 2 deletions client/modules/IDE/actions/projects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,9 @@ export function getProjects(username) {
dispatch(stopLoader());
})
.catch((error) => {
const { response } = error;
dispatch({
type: ActionTypes.ERROR,
error: response.data
error: error?.response?.data
});
dispatch(stopLoader());
});
Expand Down