Skip to content

Solved the issue with replace Behaviour. #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

perminder-17
Copy link
Contributor

@perminder-17 perminder-17 commented Nov 6, 2023

Fixes #2523

Changes: DONE THE REQUIRED CHANGES, here are the result

20231106224539.mp4

When the input field is empty, the up and down arrow keys will focus on the searchField.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@perminder-17
Copy link
Contributor Author

perminder-17 commented Nov 6, 2023

@raclim @lindapaiste ,I have made the changes. U may add this to minor relase.

@perminder-17
Copy link
Contributor Author

I have also verified that increasing the z-index of the box does not have any adverse effects on other boxes.

Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! This is a really messy area of the codebase because we've copied and modified the core CodeMirror code. Definitely not an easy one.

@lindapaiste lindapaiste merged commit a1a5efd into processing:develop Nov 10, 2023
@perminder-17
Copy link
Contributor Author

Thanks for fixing this! This is a really messy area of the codebase because we've copied and modified the core CodeMirror code. Definitely not an easy one.

So true, it was challenging for me too to make changes into this file. Anyways, thanks for your support.

@perminder-17 perminder-17 deleted the replace branch November 10, 2023 04:45
@raclim raclim added this to the PATCH Release for 2.9.3 milestone Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Replace Behavior in p5.js Web Editor
3 participants