Skip to content

refactored lodash imports #2567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

PiyushChandra17
Copy link
Contributor

@PiyushChandra17 PiyushChandra17 commented Nov 4, 2023

Fixes #2566

Changes:

  • Replaced lodash imports,
    import find from 'lodash/find'

with this,

import { find } from 'lodash'

  • Just to be consistent throughout the app, this is the way to go i think.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

I need to run this branch and check for any problems before merging.

@PiyushChandra17
Copy link
Contributor Author

@lindapaiste Sure 👍

@lindapaiste lindapaiste merged commit 5ac37e4 into processing:develop Nov 10, 2023
@raclim raclim added this to the PATCH Release for 2.9.3 milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup lodash imports ( not consistent throughout the web app)
3 participants