Skip to content

migration of assets actions to async/await #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2023
Merged

migration of assets actions to async/await #2436

merged 2 commits into from
Sep 13, 2023

Conversation

Vikram125609
Copy link
Contributor

@Vikram125609 Vikram125609 commented Sep 13, 2023 •
edited
Loading

…AssetRequest to async/await instead of callbacks

Fixes #issue-number

Changes:

Ref #2246

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@Vikram125609
migration of the function which is returned from getAssets and delete…
d5e8b15 
…AssetRequest to async/await instead of callbacks
@welcome
Copy link

welcome bot commented Sep 13, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@lindapaiste lindapaiste changed the title migration of the function which is returned from getAssets and delete… migration of assets actions to async/await Sep 13, 2023
lindapaiste
lindapaiste approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. FYI in the linked issue I was talking about the backend code. I added a comment to clarify. Regardless, this is a positive change!

@lindapaiste lindapaiste merged commit c55cf5f into processing:develop Sep 13, 2023
@lindapaiste lindapaiste mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindapaiste lindapaiste lindapaiste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vikram125609 @lindapaiste