Skip to content

Convert Searchbar.jsx to a funtional component #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 18, 2023
Merged

Convert Searchbar.jsx to a funtional component #2413

merged 3 commits into from
Nov 18, 2023

Conversation

Akshay02022
Copy link
Contributor

@Akshay02022 Akshay02022 commented Sep 11, 2023 •
edited
Loading

Ref #2358

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Sep 11, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

krishna9358
krishna9358 approved these changes Sep 11, 2023
View reviewed changes
Copy link

@krishna9358 krishna9358 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The work is done really well. The class component is changed to the functional component.

@vibhoooo
Copy link

vibhoooo commented Oct 2, 2023

Hi there!
I this issue still open?If yes i would love to work on it.

@lindapaiste lindapaiste merged commit e347dcd into processing:develop Nov 18, 2023
@raclim raclim added this to the PATCH Release for 2.9.3 milestone Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishna9358 krishna9358 krishna9358 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PATCH Release for 2.9.3
Development

Successfully merging this pull request may close these issues.
5 participants
@Akshay02022 @vibhoooo @krishna9358 @lindapaiste @raclim