Convert EmailVerificationView to function component #2401
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
24 tasks
lindapaiste
reviewed
Sep 11, 2023
| const verificationToken = this.verificationToken(); | ||
| function EmailVerificationView({ emailVerificationTokenState, verifyEmailConfirmation, t, location }) { | ||
| useEffect(() => { | ||
| const verificationToken = verificationToken(); |
There was a problem hiding this comment.
I don't think this will work due to using the same variable name for both the constant and the function.
|
I'm going to close this as we have another PR for the same component (#2405) but I appreciate for your efforts 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #issue-number
Changes:
I have verified that this pull request:
☒ has no linting errors (
npm run lint)☒ has no test errors (
npm run test)☒ is from a uniquely-named feature branch and is up to date with the
developbranch.[ ] is descriptively named and links to an issue number, i.e.
Fixes #123