The mobile Login Page 🚪

[dewanshDT]

This Project is a part of the mobile project

Changes:

I have verified that this pull request:

• has no linting errors (npm run lint)
• has no test errors (npm run test)
• is from a uniquely-named feature branch and is up to date with the develop branch.

[lindapaiste]

This is looking excellent! The breakpoint at 770px is seamless. We discussed that maybe the contents should stay vertically aligned to the center below 550px rather than shifting to the top. But either way is acceptable.

[lindapaiste]

It seems like all this media query does is increase the gap between the "sign up" and "forgot your password" lines?

[dewanshDT]

yes

[dewanshDT]

@lindapaiste, I just made the required changes.

[lindapaiste]

This looks good, and we will continue improving it in the future.

One request -- for pages like this where the main LoginView has been made responsive, we should remove the legacy mobileFirst switching in the routes.jsx file.

p5.js-web-editor/client/routes.jsx

Lines 57 to 62 in 2eb8690

	<Route
	path="/login"
	component={userIsNotAuthenticated(
	mobileFirst(responsiveForm(LoginView), LoginView)
	)}
	/>

We'll do this for each page as we tackle it until eventually we get them all.

[dewanshDT]

okay I'll remove the legacy code

[dewanshDT]

okay I'll remove the legacy code

will create a separate PR for removing all the legacy code after this

[dewanshDT]

@lindapaiste I think we should merge this