Skip to content

Fix mjml syntax for v4. #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Fix mjml syntax for v4. #2386

merged 1 commit into from
Aug 16, 2023

Conversation

catarak
Copy link
Member

@catarak catarak commented Aug 16, 2023

Fixes #2303
(Probably, but I haven't checked it with a valid Mailgun config to make sure that it works all the way through to sending the email.)

We merged a dependabot PR #2267 which included a major version bump of mjml and that caused emails to break.

Changes:

  • Import mjml2html as the default from mjml instead of a named import.
  • Remove deprecated component <mj-container> from templates.
  • Convert unitless value width="192" to px width="192px".
  • Log errors when calling mjml2html (useful in development, probably does nothing in production but idk).

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@catarak catarak changed the base branch from develop to release August 16, 2023 20:22
@release-com
Copy link

release-com bot commented Aug 16, 2023

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-c73f58a3de

@raclim raclim merged commit b4dfdb4 into release Aug 16, 2023
@raclim raclim deleted the bug/mjml branch October 11, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error sending confirmation email
3 participants