Convert Preferences
into a function component
#2335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on issue #824
Continue breaking up PR #2054 into more manageable pieces. Here I am converting
Preferences
from a class component to a function component while keeping all the logic the same. I'm not including the improvements to the font size input which were causing tests to fail. I will submit those separately.Should be merged after #2329
Changes:
Preferences
useSelector
anduseDispatch
instead ofconnect
HOC.useTranslate
hook instead ofwithTranslation
HOC.useRef
hook instead of propertythis.fontSizeInput
.useState
hook for the fontSize state. I tried to keep this as similar to before as possible so I made thestate
be an object even though this is silly.Preferences.unit.test.jsx
subject
now takes the initial state as an argument.beforeAll
effects, which were used to set props.subject
with the relevant initial state for each test, ie.subject({ lintWarning: false })
.setLintWarning
etc. and spy on on the action creator instead.props
so that tests likeexpect(props.setFontSize).toHaveBeenCalledTimes(1);
will work the same as before, even though it's not actually a prop.expect
conditions as there is no change to behavior.IDEView
<Preferences/>
.propTypes
.I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123