-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
test: add ErrorModal tests and story #2325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0428ee5
docs(ErrorModal): add stories
ecbfbee
test(ErrorModal): add spec file
e6fec7b
Merge branch 'develop' into error-modal-tests
lindapaiste 754c841
fix(ErrorModal): add proptypes
f9c4800
docs(ErrorModal): remove redundant config
cbe4672
Merge branch 'error-modal-tests' of github.com:ofhope/p5.js-web-edito…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import ErrorModal from './ErrorModal'; | ||
|
||
export default { | ||
title: 'IDE/ErrorModal', | ||
component: ErrorModal, | ||
argTypes: { | ||
closeModal: { action: 'closed' } | ||
} | ||
}; | ||
|
||
export const ForceAuthenticationErrorModal = { | ||
args: { | ||
type: 'forceAuthentication' | ||
} | ||
}; | ||
export const StaleSessionErrorModal = { | ||
args: { | ||
type: 'staleSession' | ||
} | ||
}; | ||
export const StaleProjectErrorModal = { | ||
args: { | ||
type: 'staleProject' | ||
} | ||
}; | ||
export const OauthErrorModal = { | ||
args: { | ||
type: 'oauthError' | ||
} | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
import React from 'react'; | ||
|
||
import { render, screen } from '../../../test-utils'; | ||
|
||
import ErrorModal from './ErrorModal'; | ||
|
||
jest.mock('../../../i18n'); | ||
|
||
describe('<ErrorModal />', () => { | ||
it('renders type forceAuthentication', () => { | ||
render(<ErrorModal type="forceAuthentication" closeModal={jest.fn()} />); | ||
|
||
expect(screen.getByText('Login')).toBeVisible(); | ||
expect(screen.getByText('Sign Up')).toBeVisible(); | ||
}); | ||
|
||
it('renders type staleSession', () => { | ||
render(<ErrorModal type="staleSession" closeModal={jest.fn()} />); | ||
|
||
expect(screen.getByText('log in')).toBeVisible(); | ||
}); | ||
|
||
it('renders type staleProject', () => { | ||
render(<ErrorModal type="staleProject" closeModal={jest.fn()} />); | ||
|
||
expect( | ||
screen.getByText( | ||
'The project you have attempted to save has been saved from another window', | ||
{ exact: false } | ||
) | ||
).toBeVisible(); | ||
}); | ||
|
||
it('renders type oauthError with service google', () => { | ||
render( | ||
<ErrorModal type="oauthError" service="google" closeModal={jest.fn()} /> | ||
); | ||
|
||
expect( | ||
screen.getByText('There was a problem linking your Google account', { | ||
exact: false | ||
}) | ||
).toBeVisible(); | ||
}); | ||
|
||
it('renders type oauthError with service github', () => { | ||
render( | ||
<ErrorModal type="oauthError" service="github" closeModal={jest.fn()} /> | ||
); | ||
|
||
expect( | ||
screen.getByText('There was a problem linking your GitHub account', { | ||
exact: false | ||
}) | ||
).toBeVisible(); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.