Skip to content

fix: storybook i18n strings #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2023
Merged

fix: storybook i18n strings #2324

merged 1 commit into from
Jul 25, 2023

Conversation

ofhope
Copy link
Contributor

@ofhope ofhope commented Jul 24, 2023 •
edited
Loading

A follow up to this PR #2310

Changes:

Includes i18n-test in storybook preview to render strings.

Without:
Screenshot 2023-07-25 at 9 06 20 am

With:
Screenshot 2023-07-25 at 9 03 17 am

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@ofhope ofhope changed the title fix: storybook error i18n strings fix: storybook i18n strings Jul 25, 2023
lindapaiste
lindapaiste approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lindapaiste lindapaiste merged commit 59326e8 into processing:develop Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindapaiste lindapaiste lindapaiste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofhope @lindapaiste