Skip to content

fix/exportProjectAsZip #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

adityagarg06
Copy link
Contributor

Fixes #2311

Changes:
Removed the exportProjectAsZip function and directly link to the download URL.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I can confirm that this works and that it fixes the issue so it's good to merge but I do have some further thoughts.

Initially when I mentioned using an <a> tag I was thinking about replacing the <button> itself with the <a>. However that caused styling issues. This approach with the hidden <a> tag avoids those issues so that's great. 👍

We also have export logic in the Nav component for exporting the current sketch from the editor screen. So now I'm wondering if it may be better to move your logic into a utility function which can be used in both places.

@lindapaiste lindapaiste merged commit 4a4f4d2 into processing:develop Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Actions must be plain objects when downloading sketches as zip
2 participants