Skip to content

Fix: upload modal closes when clicking inside #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

lindapaiste
Copy link
Collaborator

Fixes #2049 (comment)

Changes:

  • Add a div inside the upload modal with id "hidden-input-container".
  • Set this div as the hiddenInputContainer that Dropzone uses when appending hidden inputs to the document.

=> Clicks on the hidden input are considered "inside" the modal and will not trigger the close on outside click behavior.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@lindapaiste lindapaiste requested a review from raclim June 12, 2023 15:54
@raclim raclim mentioned this pull request Jun 22, 2023
4 tasks
@raclim raclim merged commit 784f618 into processing:develop Jun 22, 2023
@lindapaiste lindapaiste deleted the fix/upload-modal-close branch August 8, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants