Skip to content

Autocomplete++ #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2023
Merged

Autocomplete++ #2236

merged 4 commits into from
Jun 10, 2023

Conversation

peilingjiang
Copy link
Contributor

Fixes #99 and extends #1873

Changes: Extending the current dropdown hinter solution by adding a Copilot-style inline completion preview, which includes argument previews for the functions.

Screenshot 2023-06-08 at 22 42 52

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@release-com
Copy link

release-com bot commented Jun 8, 2023

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-854911fa77

@peilingjiang peilingjiang mentioned this pull request Jun 8, 2023
3 tasks
@peilingjiang
Copy link
Contributor Author

Another update that I hope would boost utility - reserved keywords and namespace objects in JavaScript -

Screenshot 2023-06-08 at 23 59 54

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates, I think the altogether the autocomplete, argument previews, and link to references make this really helpful and amazing!

@raclim raclim merged commit 9539b33 into processing:develop Jun 10, 2023
@Atcold
Copy link

Atcold commented Jun 12, 2023

Wow, impressive, @peilingjiang!
I *really* like the computational literacy idea behind P5.js, but the lack of autocompletion and hints in the online editor made the whole thing still rather hard for newcomers.
I truly believe your contribution is a major step forward towards easing the getting-started process!
Thank you *very* much!

Side question (perhaps for @raclim).
How do I enable these functionalities?
I see the PR has been merged into the develop branch.
How does a user check it out for the online editor?
Thanks!

@raclim
Copy link
Collaborator

raclim commented Jun 13, 2023

@Atcold The PR has been merged, but we haven't pushed it out live to production yet due to some bug fixes and additional testing we'd like to perform before distributing it to everyone, which we're planning to complete by the end of June. I'm hoping to provide a more consistent way to communicate when these releases will happen, but for now I'll definitely send an update when it's out live!

@raclim
Copy link
Collaborator

raclim commented Jun 28, 2023

Hi, just wanted to update that this is out live on production! :)

I made one minor change, where I set the initial preference for the Autocomplete and Hinter to 'Off' instead of 'On', since I felt this feature might be a little confusing when a new user is encountering the editor for the very first time. However, please let me know if you feel like this should be changed or have a different suggestion, thanks again for all of your work/input on this!

@asukaminato0721
Copy link

or have a different suggestion

I have some thoughts:

for those who have an account and some works, they may be familiar with the online editor. Then they may not be so confusing. So making this option on for them is a boost.

For newbies: since now there are a lot of web editors based on https://github.com/microsoft/monaco-editor, and it has auto-complete out of the box. (See https://swc.rs/playground for example). I guess even a newbie can handle it.

@Atcold
Copy link

Atcold commented Jul 12, 2023

I agree with @wuyudi.

New users would benefit from having suggestions out of the box.
They may not know such a utility exists and that it can be activated.
So, setting it initially on would help feature discoverability.

On the other side, if one dislikes the functionality (for whatever reason), one can look for ways to stop it.

In short, one doesn't know one doesn't know.
Hence, awareness should be prioritised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p5.js library Autocomplete and/or link to specific parts of reference
4 participants