Skip to content

convert Sidebar to a function component & connect it to Redux #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

lindapaiste
Copy link
Collaborator

Progress on #824

Changes:

  • Convert Sidebar from a class component to a function component.
  • Remove all props from the Sidebar component.
  • Drop some props from the IDEView which were only passed down to Sidebar and not otherwise used.
  • Select relevant portions of the Redux state using useSelector.
  • Move logic from userCanEditProject() into a reusable selector function selectCanEditSketch.
  • Access dispatch with the useDispatch hook and import all actions creators directly.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@lindapaiste lindapaiste mentioned this pull request Jun 11, 2023
4 tasks
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@raclim raclim merged commit 1d32069 into processing:develop Jul 18, 2023
@lindapaiste lindapaiste deleted the refactor/sidebar branch July 23, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants