Remove titles from SVG files - Fixes #2225 #2226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2225
Changes:
<title>
tags from all svg files.aria-label
text to atitle
attribute for a few icon buttons: play, stop, preferences, folder open/close. This will show up in a tooltip when the button is hovered. I'm not sure if we actually want this?<desc>Created with Sketch.</desc>
and<!-- Generator: Sketch 47 (45396) - http://www.bohemiancoding.com/sketch -->
.<defs></defs>
.<g>
) tags into one for some files.transform
s and wrote the three points relative to to root viewbox.currentColor
since we override the color via CSS anyway. I can roll this back if we want to keep the intrinsic color. It only matters for files which we load using the?byUrl
approach, as those will have the color that is specified in the .svg file.You'll understand the differences in svgs better if you click the <> button to "Display the source diff".
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123