Skip to content

Delete unused CSS classes, variables, and theme properties. #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

lindapaiste
Copy link
Collaborator

Changes:

  1. Find class names in .scss files which are not used anywhere in the code and delete the styles for those classes.
  2. Delete files help-modal.scss and collection-popover.scss entirely as they are not used.
  3. Found a few themify variables which are no longer used.
  4. Deleted SCSS variables which are not used in any files.

These steps were done in that order. For example, variable $lightsteelblue is used by the theme property console-info-background-color so it is only "unused" after removing that unused theme property.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@raclim raclim merged commit 01dca7f into processing:develop Jul 12, 2023
@lindapaiste lindapaiste deleted the chore/delete-unused-css branch August 8, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants