Remove duplicate document.body.className
effect
#2170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code cleanup 🧹
The components
AccountView
,CollectionView
andDashboardView
are all rendered inside of theApp
component. They do not need to set thedocument.body.className
because this is already handled by the parentApp
.Changes:
In all 3 components:
theme
frompropTypes
declarationtheme
frommapStateToProps
In
AccountView
only:react/prefer-statelesss-function
which popped up after deleting thecomponentDidMount
function.react-redux
hooks instead ofconnect
as a bunch of the properties inmapStateToProps
were not actually used.I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123