Skip to content

Convert CollectionCreate from a class to a function component. #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 3, 2023

Conversation

lindapaiste
Copy link
Collaborator

Changes:

Rewrites the CollectionCreate component from a class component to a function component. The logic is the same but the new version is 45 lines shorter and easier to maintain.

I left in the logic for displaying an error, however the converted version makes it very clear that this creationError variable is never set.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@raclim raclim merged commit aa99cdd into processing:develop May 3, 2023
@lindapaiste lindapaiste deleted the refactor/collection-create branch August 8, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants