added web editor and p5 version info to the about section #2118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 730111a.
dewanshDT
changed the title
lindapaiste
reviewed
Feb 18, 2023
| import { useTranslation } from 'react-i18next'; | ||
| import { Link } from 'react-router'; | ||
| import SquareLogoIcon from '../../../images/p5js-square-logo.svg'; | ||
| // import PlayIcon from '../../../images/play.svg'; | ||
| import AsteriskIcon from '../../../images/p5-asterisk.svg'; | ||
| import packageData from '../../../../package.json'; |
|
@lindapaiste I updated as you suggested, and It works flawlessly 🔥, take a look |
|
I think this works great please check this out and there's nothing more to work on this PR unless any UI changes are required. |
raclim
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2070
Changes:
I've made changes to the
About.jsxto show the version info of the editor and the p5.js, please check the commits to learn more.I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123